fix(models): add missing creation_time initialization in Zone class #1891
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Zone class declared creation_time as an attribute but never initialized it in __init__, causing AttributeError when accessed. Also fixes type annotations from str to int to match API timestamps.
tetienne
force-pushed
the
fix/zone-missing-creation-time
branch
from
081fb64 to
3802d1e
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a bug in the Zone class where creation_time was declared as an attribute but never initialized in the constructor, and corrects timestamp type annotations to match the actual API format.
Changes:
- Added missing
creation_timeparameter initialization inZone.__init__() - Changed timestamp type annotations from
strtointfor bothcreation_timeandlast_update_timeto match API format
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
creation_timeparameter toZone.__init__()strtointto match API formatProblem
The
Zoneclass declaredcreation_timeas an attribute but never initialized it in__init__, causingAttributeErrorwhen accessed.Test plan